[Libreoffice] [PATCH] If there's no java, don't do the java stuff
christophe.strobbe at esat.kuleuven.be
Mon Jan 9 04:04:20 PST 2012
At 18:24 8-1-2012, Korrawit Pruegsanusak wrote:
>This attached patch fixes build on windows / cygwin.
>I'm building --without-java, and it breaks because not found
>"java_uno_accessbridge", which seems java-related.
I noticed on the mailing list that David Tardon has already pushed
your patch, but I'm still curious to know: did you have the Java
Access Bridge  installed when you tested this patch (I assume you
didn't have it because the build broke)?
>So, I add a check whether we have "SOLAR_JAVA" before doing this thing.
So java_uno_accessbridge is only added when "SOLAR_JAVA" is set to
"TRUE", which AFAICT is something that happens at compile time.
I assume this patch is part of the work to (locate and) reduce Java
dependencies in order to (1) make it easier for developers to build
LibreOffice (e.g. when working on patches that have nothing to do
with Java), and (2) eventually transition to a LibreOffice without
any Java (i.e. for everybody, not just developers). So when the Java
Accessibility API has been replaced by the IAccessible2 API, and when
the Java-dependent wizards have been replaced, SOLAR_JAVA will become
irrelevant. I'm basically trying to increase my understanding of
what's going on, so feel free to correct me of I get it wrong :-)
>My incremental build went fine after this patch, and the program
>started well :-)
>Please feel free to comment :-)
K.U.Leuven - Dept. of Electrical Engineering - SCD
Research Group on Document Architectures
Kasteelpark Arenberg 10 bus 2442
tel: +32 16 32 85 51
Open source for accessibility: results from the AEGIS project
Please don't invite me to Facebook, Quechup or other "social
More information about the LibreOffice