[Libreoffice] npshell build / functionality [was: Re: Tinderbox failure, last success: 2011-12-05 19:05:50]

[Matúš Kukan]

On 10 January 2012 16:14, Michael Stahl <mstahl at redhat.com> wrote:
> well the .def file is only for Windows, we don't have anything in gbuild
> to convert between a bunch of different map file formats like the old
> build system could because we're trying for "less insane"...
>
> so something like #ifdef UNX SAL_DLLPUBLIC_EXPORT would be needed...
>
> on the other hand the npapi.h header is checked into git, does not come
> from a tarball, and has already been modified; i wonder if editing that
> to add dll-exports is the easiest way to fix this?

I think we should add DLLPUBLIC_EXPORT macros ..
And we don't have to modify npapi.h directly but create different
npapi.h to be included some ugly way as in:
i18npool/source/breakiterator/Makefile:37

Because there is also possibility to use SYSTEM_MOZILLA_HEADERS.
I don't know if anybody use that but if yes, we would need somehow get
path to the npapi.h file.
I guess that could be doable.

I can volunteer for this.

Best,
Matus