[Libreoffice] .: sc/qa sc/source

[Kohei Yoshida]

Hi Michael,

On Wed, 2012-01-11 at 13:51 +0100, Michael Stahl wrote:
> hi Kohei,
> 
> i get an assertion in the smoketest because of this commit:
> 
> > #0  sal_detail_logFormat(level = SAL_DETAIL_LOG_LEVEL_WARN, area = 0x7f75465b5032 "legacy.tools", where = 0x7f75465b57e0 "/data/lo/core_master/svx/source/svdraw/svdmodel.cxx:1977: ", format = 0x7f75465b5770 "SdrModel::GetPage: Access out of range (!)") at /data/lo/core_master/sal/osl/all/log.cxx:178
> > #1  SdrModel::GetPage(this = 0x30788a0, nPgNum = 1) at /data/lo/core_master/svx/source/svdraw/svdmodel.cxx:1977
> > #2  ScDrawLayer::ResetTab(this = 0x30788a0, nStart = 0, nEnd = 2) at /data/lo/core_master/sc/source/core/data/drwlayer.cxx:486
> > #3  ScDrawLayer::ScAddPage(this = 0x30788a0, nTab = 0) at /data/lo/core_master/sc/source/core/data/drwlayer.cxx:393
> > #4  ScDocument::InitDrawLayer(this = 0x31b5698, pDocShell = 0x31b5620) at /data/lo/core_master/sc/source/core/data/documen9.cxx:157
> > #5  ScDocShell::MakeDrawLayer(this = 0x31b5620) at /data/lo/core_master/sc/source/ui/docshell/docsh2.cxx:221
> > #6  ScTabView::MakeDrawLayer(this = 0x3036120) at /data/lo/core_master/sc/source/ui/view/tabview2.cxx:1348
> > #7  ScTabViewShell::ScTabViewShell(this = 0x30360a0, pViewFrame = 0x304fd30, pOldSh = 0x0) at /data/lo/core_master/sc/source/ui/view/tabvwsh4.cxx:1759
> > #8  ScTabViewShell::CreateInstance(pFrame = 0x304fd30, pOldView = 0x0) at /data/lo/core_master/sc/source/ui/view/tabvwsh.cxx:97
> 
> reverting the change to drwlayer.cxx ScDrawLayer::ScAddPage i don't get
> the smoketest assertion, but then the new unit test fails.

Yes, that can make some drawing objects not saved to disk.  Pretty bad.
We can't afford to revert it.

Fixing the assertion should be easy.  Just calling GetPageCount() and
using it to avoid accessing non-existing page.  I'll take care of it
this morning.

Best,

Kohei