[Libreoffice] [PATCH] proposed fix for fdo#44283

[Caolán McNamara]

On Tue, 2012-01-10 at 13:38 -0800, julien2412 wrote:
> I replaced 0 by BROWSER_INVALIDID, it compiles and seems to work.
> 
> I propose this patch : 
> http://nabble.documentfoundation.org/file/n3648948/patch.txt patch.txt 

Reading your patch and also
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f7ed67f2cf79fd067c1634e8f7c3f8a17792f2e5

"GetColumnId: return BROWSER_INVALIDID, not 0 (== id of handle column)
for an invalid column; adapt code calling GetColumnId to this change."

It looks like you're right at this was a missed adaption of the
GetColumnId change.

> Is it ok for you ? If yes I can commit and push on master (3.5 too ?)

Looks good to me on the surface anyway. Go for it I say for master and
3.5. Lionel ? are we right here ?

C.