[Libreoffice] [REVIEW][3-4] date change regression fdo#44385

Michael Stahl mstahl at redhat.com
Thu Jan 12 14:27:02 PST 2012

On 12/01/12 16:55, Noel Power wrote:
> Be good to get this in, afaict this shouldn't cause any problems
> see attached patch
> Noel

looking at the change, i notice that now it is independent of the
operation being performed, while the code that was originally removed in
adcba12537d047f5ad65334b65512615311cf872 checked for addition only (as
the comment says):

> -                    // #45465 Date needs with "+" a special handling
> -                    if( eOp == SbxPLUS && (GetType() == SbxDATE || rOp.GetType() == SbxDATE ) )
> -                        aL.eType = SbxDATE;

is that intentional?

i'm +1 for putting the original change back, and perhaps also for your
changed variant if you have a good explanation :)

More information about the LibreOffice mailing list