[Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

Ivan Timofeev timofeev.i.s at gmail.com
Fri Jan 13 10:22:30 PST 2012

Hi there,


this patch partially reverts
because the following change made the option
"[ ] Use only paper tray from printer preferences" useless:

@@ -1147,8 +1156,13 @@ void PrinterController::printFilteredPage( int 
i_nPage )
mpImplData->mpPrinter->SetMapMode( MAP_100TH_MM );
// aPageSize was filtered through mpImplData->getRealPaperSize already 
by getFilteredPageFile()
mpImplData->mpPrinter->SetPaperSizeUser( aPageSize.aSize, ! 
mpImplData->isFixedPageSize() );
+ if( mpImplData->mnFixedPaperBin != -1 &&
+ mpImplData->mpPrinter->GetPaperBin() != mpImplData->mnFixedPaperBin )
+ {
+ mpImplData->mpPrinter->SetPaperBin( mpImplData->mnFixedPaperBin );
+ }

Instead, the mnPaperBin value now keeps the user's choice of paper tray, 
and it is used in the modifyJobSetup function as default and can be 
overridden there by a page's own paper tray (only in sw and sd AFAIK).

1. I haven't got a multitray printer to test this. (However, the added 
printf shows that it works for the normal layout and don't work for the 
brochure layout.)
2. Frankly speaking I don't comprehend how the printing code works :(

Any help would be appreciated. :)

Best Regards,

More information about the LibreOffice mailing list