[Libreoffice] [Libreoffice-commits] .: connectivity/source "WaE: fix misc. SvStream operator problems."

Michael Meeks michael.meeks at suse.com
Thu Jan 19 04:50:12 PST 2012


On Thu, 2012-01-19 at 11:10 +0100, Stephan Bergmann wrote:
> > --- a/connectivity/source/drivers/dbase/DTable.cxx
...
> >               (*m_pFileStream)<<  cTyp;
> >               if ( nDbaseType == VisualFoxPro )
> > -                (*m_pFileStream)<<  (nRecLength-1);
> > +                (*m_pFileStream)<<  sal_uInt16(nRecLength-1);
> 
> This would previously have been written as four bytes.  Are you sure 
> that writing it as two bytes is what is wanted?

	Oh - I didn't want to change anything, beyond fixing the compilation
bug. nRecLength is a sal_uInt16 - so subtracting one turns it into an
int ? if so please do fix that up.

> >               else
> >                   m_pFileStream->Write(aBuffer, 4);

	I guess that would be the equivalent as zeros for non-VisualFoxPro :-)

	Any chance you can fix it up ?

	Thanks,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list