[Libreoffice] [PUSHED] Re: [PATCH] [REVIEW-3-5] fdo#44025 isLast() erroneously returns true

Michael Stahl mstahl at redhat.com
Fri Jan 20 10:29:51 PST 2012


On 19/01/12 20:47, Lionel Elie Mamane wrote:
> Attached patch fixes fdo#44025; the original symptom is "search in a
> database does not go beyond prefetch window". The underlying reason is
> that dbaccess::ORowSetCache::isLast() returns true on the last line of
> the *prefetch* *window* even if it is not the last line of the
> data. This patch ensures that the underlying statistics are kept up to
> date, so that isLast() gives a correct result.
> 
> 
> Please apply to libreoffice-3-5.

it almost looks like this was accidentally commented out in
1ae17f5b03cc14844fb600ca3573a96deb37ab3b; your explanation sounds
entirely plausible.

pushed:

http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=fd29a786e3e94710d1e79c0a6c510491ef461302



More information about the LibreOffice mailing list