[Libreoffice] [PATCH V2] replace open-coded array with std::vector in ScColumn

Kohei Yoshida kohei.yoshida at suse.com
Fri Jan 20 14:19:06 PST 2012

Hi Noel,

On Sat, 2012-01-21 at 00:01 +0200, Noel Grandin wrote:
> I hereby confirm that this and my future contributions are licensed
> under GPLv3+/LGPLv3+/MPL1.1+

Thanks for the confirmation.  Just pushed to master, with my follow-up
changes (as I mentioned in my earlier post).

> The problem was in ScColumn::Resize
> I was calling vector::resize when the correct call is vector::reserve

Ah! Ok.  I didn't spot that either.  Good catch.

> At some point I should rename the ScColumn::Resize method to match the
> std::vector naming

Yup.  That makes sense.  No objection with that.



Kohei Yoshida, LibreOffice hacker, Calc

More information about the LibreOffice mailing list