[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

[Kohei Yoshida]

On Tue, 2012-01-24 at 12:24 +0100, Eike Rathke wrote:
> Hi,
> 
> On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote:
> 
> >  Did you check with libreoffice 3-5? I think that eike's work for date
> > patterns is missing in 3-5
> 
> Yes, that's only on master.
> 
> > so that this patch does reopen the bug we
> > discussed on IRC. At least your unit test fails and I think we should
> > check that before adding the patch to 3-5.
> 
> Relying on date patterns sounds very fragile, they vary between locales
> and may change at any time.

Sure, but that's how it used to work.  It's fragile, yes, but to fix it
properly we'd have to make more invasive changes, and definitely not for
3.5.

-- 
Kohei Yoshida, LibreOffice hacker, Calc