[Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

[Tim Hardeck]

Hi Kendy,

thanks for the commit and cleanup. I also thought that 1.2 was a better fit so fine with me.

Regards
Tim

On Wednesday 25 January 2012 12:46:02 Jan Holesovsky wrote:
> Hi Tim,
> 
> On 2012-01-24 at 17:38 +0100, Tim Hardeck wrote:
> 
> > thanks for the information, I have attached a new patch and also 25% is enforced like Stefan requested.
> 
> Great stuff - I've pushed that:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d2ddc161e4b296febe9e54c3cfc9270310bfe
> 
> I did a minor stylistic cleanup - I've hidden the helper functions
> (supposedly you did not want to make them public?), and reduced the
> indentation in zoomtools.cxx; no point in having the entire file
> starting at 8th position - I hope it is OK for you :-)
> 
> Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better
> here, the 1.1 means way too much wheel rotation to increase / decrease
> the zoom considerably; but of course can be changed easily when another
> value feels better.  And now with your nice embedding of this stuff,
> even the pre-defined values would be easy to implement, should there be
> demand for that - nice work!
> 
> Thank you,
> Kendy
> 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

-- 
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
T: +49 (0) 911 74053-0  F: +49 (0) 911 74053-483
http://www.suse.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120125/ae71ac53/attachment.pgp>