[Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

Michael Stahl mstahl at redhat.com
Thu Jan 26 09:21:16 PST 2012

On 26/01/12 14:20, Eike Rathke wrote:
> Hi,
> please review and cherry-pick to 3-5, 3.5.0 and 3-4
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e
> Resolves https://bugs.freedesktop.org/show_bug.cgi?id=38595

ooh, Calc also has this kind of problem :)

your fix is an improvement, but i have doubts about taking the width
from the fo:border at all if there is a style:border-line-width:

the idea is that for double borders, the 3 parts of
style:border-line-width should add up to the total width of the border;
so if the fo:border contains a value different from the sum of the 3
parts then there is probably a problem.. i'd call such a document invalid.

but i suppose it would be legal to omit the width from fo:border for
double borders? what does this fix do then? initialize the width to zero?

i've fixed this differently in my patch for writer, which Cedric has
promised to review any minute now:

More information about the LibreOffice mailing list