[Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

Michael Stahl mstahl at redhat.com
Thu Jan 26 10:35:00 PST 2012

On 26/01/12 19:30, Michael Stahl wrote:
> On 26/01/12 16:21, Cedric Bosdonnat wrote:
>> Hi all,
>> Could someone review and cherry-pick this commit to -3-5, -3-5-0 and
>> -3-4?
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889
> your fix looks good to me, except for the line:
>   sal_uInt16 nMaxDstId = *aIds.end();

oops, now it occurs to me that dereferencing end() is a bad idea in any
case, you probably want to use rbegin() instead :)

> if i'm reading this right, then aIds could be empty here, if the source
> document has seq field references, and the target document has no seq
> field references but note references.
> suggest to wrap an "if (!aIds.empty())" around the whole block?
> no need to adjust anything in that case, right?

More information about the LibreOffice mailing list