[Libreoffice] [PATCH] Reduced duplicate code detected by simian

[Eike Rathke]

Hi Christina,

Nice find. Just to mention that this

> +    SAL_DLLPRIVATE Color ImplDrawModeToColor( Color );
> +Color OutputDevice::ImplDrawModeToColor( const Color rColor )

not only should be a const method as Stephan mentioned, but also should
get passed a   const Color& rColor   reference instead, otherwise an
unnecessary temporary copy of the Color object would be created as
argument. Muthu already changed that in the commit.

Thanks
  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120126/1c4f3ff3/attachment.pgp>