[Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

Eike Rathke erack at redhat.com
Thu Jan 26 15:23:07 PST 2012

Hi Kohei,

On Friday, 2012-01-27 00:03:29 +0100, Eike Rathke wrote:

> > Then the second part is in ScDPOutput::Output(), where the old content
> > gets removed before writing out a new one.  The thing is, this method
> > only gets called from ScDPObject::Output(), and that method already
> > deletes the old content which makes the removal code in ScDPOutput
> > unnecessary.  So, when updating or refreshing the pivot table output,
> > calc was essentially deleting the range twice.
> That's indeed unnecessary.

Or is it? Before that, CalcSizes() is called that modifies nTabEndCol
and nTabEndRow that are passed to pDoc->DeleteAreaTab(), didn't check if
that actually may grow the area that was cleared before.


LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120127/eee7ff86/attachment.pgp>

More information about the LibreOffice mailing list