[Libreoffice] LibreOffice Code Cleanup Patch

Stephan Bergmann sbergman at redhat.com
Thu Jan 26 23:52:43 PST 2012

On 01/27/2012 05:49 AM, Muthu Subramanian K wrote:
> Its nice to see those patches. But, it will be nice to see/use the
> tools/scripts directly? Especially if they can be hooked to git (like
> the current white space/tabs removal ones)?
> @lubos: Alexander is good with scripts, so as a starter he wanted to do
> something like
> "http://cgit.freedesktop.org/libreoffice/core/commit/?id=59cefd339d0c3fcde5b614d7f142a957397672d9"
> . So, yes, I had asked him to give it a shot. I guess, the patch is good
> as well?

One problem with scripted mass-modifications is that they might be too 
aggressive.  For example, with a script that changes "( )" -> "()", 
there might be legitimate uses of "( )" (within string literals, say) 
that must not be changed.  And if the resulting patch is large, even a 
review may not find those erroneous changes.

Hence, it would be highly desirable to publish any used scripts along 
with such a patch, so that reviewers can judge better how "dangerous" 
the patch might be.


More information about the LibreOffice mailing list