[Libreoffice] Duplicate expression in sd/source/ui/view/outlview.cxx

Ivan Timofeev timofeev.i.s at gmail.com
Fri Jan 27 23:55:48 PST 2012

Hi Julien,

28.01.2012 11:12, julien2412 пишет:
> So either the duplicated part (obviously "mpOutliner != NULL") could be
> simply removed
> or perhaps the author thought about this  :
>   mpOutlineViewShell != NULL

mpOutlineViewShell is initialized and dereferenced in the ctor, and 
keeps its value all the time. Thus it can't be NULL. (I'd like to have 
references instead of pointers in such cases. :)

It seems that the author of the commit just didn't notice the first 
"mpOutliner != NULL".

Hope that helps,

More information about the LibreOffice mailing list