[Libreoffice] [PATCH] fdo#45285 - Use more revealing error message for not allowed sheet names

Albert Thuswaldner albert.thuswaldner at gmail.com
Sat Jan 28 12:06:05 PST 2012


Hi,

> Hi Albert,
>
>> ... The sheet name must not be a duplicate of an existing name.
>
> Yes.
>
>> ... Further it must be 31 or fewer characters and can not contain the >
>> characters [ ] * ? / \ .
>
> No, AFAIK there is no " <= 31" restriction. And '.' isn't a forbidden
> character, see the source code:
> http://cgit.freedesktop.org/libreoffice/core/tree/sc/source/core/data/document.cxx#n250
>
> But anyway improving this error message would be great! :) I believe that
> most people hate meaningless error messages.
>
> Thanks,
> Ivan

Thanks for the feed-back, Ivan! I have updated the patch accordingly.
/Albert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Updated-error-message-for-Invalid-sheet-name.patch
Type: text/x-patch
Size: 847 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120128/3e115539/attachment.bin>


More information about the LibreOffice mailing list