[Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

[Lionel Elie Mamane]

On Mon, Jan 30, 2012 at 02:08:54PM +0000, Michael Meeks wrote:

> On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote:

>> The attached
>> 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch
>> appears to be completely unrelated?

> 	True :-)

Yes, I used an older email as a template and forgot to replace the
attached patch.

> I suspect the patch intended is attached; the patch it refers to is
> already merged. This has my ack - seems like a nice piece of cleanup
> and bug fix in one.

So, I had thought that this was too invasive for a "late release
candidate" change, so I did a less invasive version of it for
libreoffice-3-5. The patch you dug up is the corresponding master
commit.

I attach here the "less invasive" variant originally meant for
libreoffice-3-5.

However, if people are happy with cherry-picking the (more invasive)
master commit, by all means, cherry-pick it. This would have the
advantage of not "forking" these codepaths between 3.5 and 3.6, which
means these codepaths will get more testing and if a remaining bug is
discovered, then when we correct the bug in both of them by just
cherry-picking from master to libreoffice-3-5 in future. It has the
disadvantage that, well, more invasive change close to
release. <shrug>


> From 19ef5bcc8d9dbcf965f79495e1afd86ac0f22c31 Mon Sep 17 00:00:00 2001
> From: Lionel Elie Mamane <lionel at mamane.lu>
> Date: Tue, 24 Jan 2012 22:21:41 +0100
> Subject: [PATCH] use proper sizes for SQL(Get|Set)StmtAttr

> Fixes fdo#34432 (driver smashes our stack)

> Continuation of
> commit 9a466d9718cceeb4ace9e3352a173c7b62387eee
> Author: Lionel Elie Mamane <lionel at mamane.lu>
> Date:   Tue Nov 29 17:49:36 2011 +0100

>     ODBC: use right integer length to get Statement Options

-- 
Lionel