[Libreoffice] [Libreoffice-ux-advise] [PATCH] [PUSHED] fdo#45285 - Use more revealing error message for not allowed sheet names

Albert Thuswaldner albert.thuswaldner at gmail.com
Mon Jan 30 11:40:25 PST 2012


On Mon, Jan 30, 2012 at 10:07, Stefan Knorr (Astron)
<heinzlesspam at googlemail.com> wrote:
> Hi Albert, Korrawit, Ivan,
> the idea sounds good, ... patch is simple, and the details seem to be
> correct now. Thus, I've taken the liberty to replace "can" by "may"
> and then push to master.
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=e70541dc4627d63f294837f3eefc1cc25398b703

Thanks for taking care of this (and yes "may" instead of "can" sounds better).

Just a thought: should we push this to the 3.5 branch? This is a small
polish of the user experience and it might be
good to have it in a release soon, instead of waiting for 3.6. Also
the bug report was written against 3.5.0rc1...

> Also, thanks for the patch.
> Albert, could you please confirm that you submitted your patch under
> LGPL3+/MPL? (If you plan on doing more patches, please consider just
> writing a blanket mail saying that you want to always commit under
> these licenses and then add yourself to [1].)



More information about the LibreOffice mailing list