[Libreoffice] Same expression on both sides of '||' in svtools/source/filter/sgvtext.cxx

[Eike Rathke]

Hi julien2412,

On Monday, 2012-01-30 11:24:18 -0800, julien2412 wrote:

>     139 #define  EscSet    '' /* Flag setzen                                              
> */
> 
> Now why EscSet = EscReset = EscToggl ?
> I took a look at the git history and found the commit
> 9e5584a82633442467a53ccc08c3380070178a38 included something about "EscSet".
> I tried to copy paste here to show you and had empty values (whereas it's
> not empty at all !) :
> + #define  EscSet    '' /* Flag setzen                                              
> */
> + #define  EscReset  '' /* Flag loeschen                                            
> */
> + #define  EscDeflt  '\x11' /* Flag auf default setzen                               
> */
> + #define  EscToggl  '' /* Flag Toggeln                                             
> */

> Special characters/encoding problem ?

Yeah, great, literal control characters in source code :-/
These should be

#define  EscSet    '\x1e'
#define  EscReset  '\x1f'
#define  EscDeflt  '\x11'
#define  EscToggl  '\x1d'

Good catch!

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120130/91978067/attachment.pgp>