[Libreoffice] [PATCH] Remove unused code
Noel Power
nopower at suse.com
Tue Jan 31 02:07:57 PST 2012
Hi Elton
First thanks for submitting your patch, it's appreciated however could I
ask if you could please repost your patch as an attachment [1] ? patch
content inline in a mail message just does't work as the mail client
breaks the lines in such a way as the patch program no longer
understands the diff. A patch as an attachmentwill help the reviewers
integrate your work easily, thanks again
Noel
p.s. could you also confirm you contribution is under the MPL 1.1 /
GPLv3+ / LGPLv3+ license(s)
[1]
http://wiki.documentfoundation.org/Development/Patch_Handling_Guidelines#How_to_submit_a_patch
On 31/01/12 07:58, Elton Chung wrote:
> ---
> sc/inc/scdll.hxx | 1 -
> sc/source/core/inc/ddelink.hxx | 1 -
> sc/source/core/tool/ddelink.cxx | 11 ---------
> sc/source/ui/app/scdll.cxx | 10 --------
> sc/source/ui/dbgui/fieldwnd.cxx | 5 ----
> sc/source/ui/inc/areasave.hxx | 1 -
> sc/source/ui/inc/cellmergeoption.hxx | 1 -
> sc/source/ui/inc/fieldwnd.hxx | 1 -
> sc/source/ui/inc/scuitphfedit.hxx | 4 ---
> sc/source/ui/pagedlg/scuitphfedit.cxx | 39 ---------------------------------
> sc/source/ui/undo/areasave.cxx | 5 ----
> sc/source/ui/view/cellmergeoption.cxx | 9 -------
> unusedcode.easy | 9 -------
> 13 files changed, 0 insertions(+), 97 deletions(-)
>
> diff --git a/sc/inc/scdll.hxx b/sc/inc/scdll.hxx
> index 93cff7e..43a9c9f 100644
> --- a/sc/inc/scdll.hxx
> +++ b/sc/inc/scdll.hxx
> @@ -61,7 +61,6 @@ public:
>
> // DLL-init/exit-code must be linked to the DLL only
> static void Init(); // called directly after loading the DLL
> - static void Exit(); // called directly befor unloading the DLL
>
> static sal_uLong DetectFilter( SfxMedium& rMedium, const
> SfxFilter** ppFilter,
> SfxFilterFlags nMust,
> SfxFilterFlags nDont );
> diff --git a/sc/source/core/inc/ddelink.hxx b/sc/source/core/inc/ddelink.hxx
> index e3794e4..216d6d6 100644
> --- a/sc/source/core/inc/ddelink.hxx
> +++ b/sc/source/core/inc/ddelink.hxx
> @@ -87,7 +87,6 @@ public:
> const String& GetItem() const { return aItem; }
> sal_uInt8 GetMode() const { return nMode; }
>
> - void ResetValue(); // Wert zuruecksetzen
> void TryUpdate();
>
> sal_Bool NeedsUpdate() const { return bNeedUpdate; }
> diff --git a/sc/source/core/tool/ddelink.cxx b/sc/source/core/tool/ddelink.cxx
> index 3bd75ae..5d36e52 100644
> --- a/sc/source/core/tool/ddelink.cxx
> +++ b/sc/source/core/tool/ddelink.cxx
> @@ -228,17 +228,6 @@ sfx2::SvBaseLink::UpdateResult ScDdeLink::DataChanged(
> return SUCCESS;
> }
>
> -void ScDdeLink::ResetValue()
> -{
> - pResult.reset();
> -
> - // Es hat sich was getan...
> - // Tracking, FID_DATACHANGED etc. passiert von aussen
> -
> - if (HasListeners())
> - Broadcast( ScHint( SC_HINT_DATACHANGED, ScAddress(), NULL ) );
> -}
> -
> void ScDdeLink::ListenersGone()
> {
> sal_Bool bWas = bIsInUpdate;
> diff --git a/sc/source/ui/app/scdll.cxx b/sc/source/ui/app/scdll.cxx
> index 9cf9555..0a57bf6 100644
> --- a/sc/source/ui/app/scdll.cxx
> +++ b/sc/source/ui/app/scdll.cxx
> @@ -312,16 +312,6 @@ void ScDLL::Init()
> // StarOne Services are now handled in the registry
> }
>
> -void ScDLL::Exit()
> -{
> - // the SxxModule must be destroyed
> - ScModule **ppShlPtr = (ScModule**) GetAppData(SHL_CALC);
> - delete (*ppShlPtr);
> - (*ppShlPtr) = NULL;
> -
> - // ScGlobal::Clear ist schon im Module-dtor
> -}
> -
> //------------------------------------------------------------------
> // Statusbar
> //------------------------------------------------------------------
> diff --git a/sc/source/ui/dbgui/fieldwnd.cxx b/sc/source/ui/dbgui/fieldwnd.cxx
> index 40eb873..9139be4 100644
> --- a/sc/source/ui/dbgui/fieldwnd.cxx
> +++ b/sc/source/ui/dbgui/fieldwnd.cxx
> @@ -254,11 +254,6 @@ size_t ScDPFieldControlBase::GetSelectedField() const
> return mnFieldSelected;
> }
>
> -void ScDPFieldControlBase::SetSelectedField(size_t nSelected)
> -{
> - mnFieldSelected = nSelected;
> -}
> -
> vector<ScDPFieldControlBase::FieldName>& ScDPFieldControlBase::GetFieldNames()
> {
> return maFieldNames;
> diff --git a/sc/source/ui/inc/areasave.hxx b/sc/source/ui/inc/areasave.hxx
> index c9ff348..1a0b1cd 100644
> --- a/sc/source/ui/inc/areasave.hxx
> +++ b/sc/source/ui/inc/areasave.hxx
> @@ -78,7 +78,6 @@ public:
>
> const ScAreaLinkSaver* operator[](size_t nIndex) const;
> size_t size() const;
> - void clear();
> void push_back(ScAreaLinkSaver* p);
> };
>
> diff --git a/sc/source/ui/inc/cellmergeoption.hxx
> b/sc/source/ui/inc/cellmergeoption.hxx
> index ad5fe34..62e4279 100644
> --- a/sc/source/ui/inc/cellmergeoption.hxx
> +++ b/sc/source/ui/inc/cellmergeoption.hxx
> @@ -44,7 +44,6 @@ struct ScCellMergeOption
> SCROW mnEndRow;
> bool mbCenter;
>
> - explicit ScCellMergeOption();
> explicit ScCellMergeOption(const ScRange& rRange);
> explicit ScCellMergeOption(SCCOL nStartCol, SCROW nStartRow,
> SCCOL nEndCol, SCROW nEndRow,
> diff --git a/sc/source/ui/inc/fieldwnd.hxx b/sc/source/ui/inc/fieldwnd.hxx
> index 2b232cf..49fc2ed 100644
> --- a/sc/source/ui/inc/fieldwnd.hxx
> +++ b/sc/source/ui/inc/fieldwnd.hxx
> @@ -149,7 +149,6 @@ public:
> void GetExistingIndex( const Point& rPos, size_t& rnIndex );
>
> size_t GetSelectedField() const;
> - void SetSelectedField(size_t nSelected);
>
> /** Selects the next field. Called i.e. after moving a field from
> SELECT area. */
> void SelectNext();
> diff --git a/sc/source/ui/inc/scuitphfedit.hxx
> b/sc/source/ui/inc/scuitphfedit.hxx
> index b8c3e20..f14d5fc 100644
> --- a/sc/source/ui/inc/scuitphfedit.hxx
> +++ b/sc/source/ui/inc/scuitphfedit.hxx
> @@ -120,7 +120,6 @@ class ScRightHeaderEditPage : public ScHFEditPage
> {
> public:
> static SfxTabPage* Create( Window* pParent, const SfxItemSet& rCoreSet );
> - static sal_uInt16* GetRanges();
>
> private:
> ScRightHeaderEditPage( Window* pParent, const SfxItemSet& rSet );
> @@ -132,7 +131,6 @@ class ScLeftHeaderEditPage : public ScHFEditPage
> {
> public:
> static SfxTabPage* Create( Window* pParent, const SfxItemSet& rCoreSet );
> - static sal_uInt16* GetRanges();
>
> private:
> ScLeftHeaderEditPage( Window* pParent, const SfxItemSet& rSet );
> @@ -144,7 +142,6 @@ class ScRightFooterEditPage : public ScHFEditPage
> {
> public:
> static SfxTabPage* Create( Window* pParent, const SfxItemSet& rCoreSet );
> - static sal_uInt16* GetRanges();
>
> private:
> ScRightFooterEditPage( Window* pParent, const SfxItemSet& rSet );
> @@ -156,7 +153,6 @@ class ScLeftFooterEditPage : public ScHFEditPage
> {
> public:
> static SfxTabPage* Create( Window* pParent, const SfxItemSet& rCoreSet );
> - static sal_uInt16* GetRanges();
>
> private:
> ScLeftFooterEditPage( Window* pParent, const SfxItemSet& rSet );
> diff --git a/sc/source/ui/pagedlg/scuitphfedit.cxx
> b/sc/source/ui/pagedlg/scuitphfedit.cxx
> index d688d6d..6eee2dd 100644
> --- a/sc/source/ui/pagedlg/scuitphfedit.cxx
> +++ b/sc/source/ui/pagedlg/scuitphfedit.cxx
> @@ -65,26 +65,8 @@
>
> // STATIC DATA -----------------------------------------------------------
>
> -static sal_uInt16 pPageRightHeaderRanges[] = { SID_SCATTR_PAGE_HEADERRIGHT,
> - SID_SCATTR_PAGE_HEADERRIGHT,
> - 0 };
> -
> -static sal_uInt16 pPageRightFooterRanges[] = { SID_SCATTR_PAGE_FOOTERRIGHT,
> - SID_SCATTR_PAGE_FOOTERRIGHT,
> - 0 };
> -
> -static sal_uInt16 pPageLeftHeaderRanges[] = { SID_SCATTR_PAGE_HEADERLEFT,
> - SID_SCATTR_PAGE_HEADERLEFT,
> - 0 };
> -
> -static sal_uInt16 pPageLeftFooterRanges[] = { SID_SCATTR_PAGE_FOOTERLEFT,
> - SID_SCATTR_PAGE_FOOTERLEFT,
> - 0 };
> -
> -
> static ScEditWindow* pActiveEdWnd = NULL;
>
> -
> //========================================================================
> // class ScHFEditPage
> //
> @@ -927,15 +909,9 @@ ScRightHeaderEditPage::ScRightHeaderEditPage(
> Window* pParent, const SfxItemSet&
>
> // -----------------------------------------------------------------------
>
> -sal_uInt16* ScRightHeaderEditPage::GetRanges()
> - { return pPageRightHeaderRanges; }
> -
> -// -----------------------------------------------------------------------
> -
> SfxTabPage* ScRightHeaderEditPage::Create( Window* pParent, const
> SfxItemSet& rCoreSet )
> { return ( new ScRightHeaderEditPage( pParent, rCoreSet ) ); };
>
> -
> //========================================================================
> // class ScLeftHeaderEditPage
> //========================================================================
> @@ -947,11 +923,6 @@ ScLeftHeaderEditPage::ScLeftHeaderEditPage(
> Window* pParent, const SfxItemSet& r
>
> // -----------------------------------------------------------------------
>
> -sal_uInt16* ScLeftHeaderEditPage::GetRanges()
> - { return pPageLeftHeaderRanges; }
> -
> -// -----------------------------------------------------------------------
> -
> SfxTabPage* ScLeftHeaderEditPage::Create( Window* pParent, const
> SfxItemSet& rCoreSet )
> { return ( new ScLeftHeaderEditPage( pParent, rCoreSet ) ); };
>
> @@ -966,11 +937,6 @@ ScRightFooterEditPage::ScRightFooterEditPage(
> Window* pParent, const SfxItemSet&
>
> // -----------------------------------------------------------------------
>
> -sal_uInt16* ScRightFooterEditPage::GetRanges()
> - { return pPageRightFooterRanges; }
> -
> -// -----------------------------------------------------------------------
> -
> SfxTabPage* ScRightFooterEditPage::Create( Window* pParent, const
> SfxItemSet& rCoreSet )
> { return ( new ScRightFooterEditPage( pParent, rCoreSet ) ); };
>
> @@ -985,11 +951,6 @@ ScLeftFooterEditPage::ScLeftFooterEditPage(
> Window* pParent, const SfxItemSet& r
>
> // -----------------------------------------------------------------------
>
> -sal_uInt16* ScLeftFooterEditPage::GetRanges()
> - { return pPageLeftFooterRanges; }
> -
> -// -----------------------------------------------------------------------
> -
> SfxTabPage* ScLeftFooterEditPage::Create( Window* pParent, const
> SfxItemSet& rCoreSet )
> { return ( new ScLeftFooterEditPage( pParent, rCoreSet ) ); };
>
> diff --git a/sc/source/ui/undo/areasave.cxx b/sc/source/ui/undo/areasave.cxx
> index 7d4e572..e382102 100644
> --- a/sc/source/ui/undo/areasave.cxx
> +++ b/sc/source/ui/undo/areasave.cxx
> @@ -214,11 +214,6 @@ size_t ScAreaLinkSaveCollection::size() const
> return maData.size();
> }
>
> -void ScAreaLinkSaveCollection::clear()
> -{
> - maData.clear();
> -}
> -
> void ScAreaLinkSaveCollection::push_back(ScAreaLinkSaver* p)
> {
> maData.push_back(p);
> diff --git a/sc/source/ui/view/cellmergeoption.cxx
> b/sc/source/ui/view/cellmergeoption.cxx
> index 68e9d8a..4c5f573 100644
> --- a/sc/source/ui/view/cellmergeoption.cxx
> +++ b/sc/source/ui/view/cellmergeoption.cxx
> @@ -30,15 +30,6 @@
> #include "cellmergeoption.hxx"
> #include "address.hxx"
>
> -ScCellMergeOption::ScCellMergeOption() :
> - mnStartCol(0),
> - mnStartRow(0),
> - mnEndCol(0),
> - mnEndRow(0),
> - mbCenter(false)
> -{
> -}
> -
> ScCellMergeOption::ScCellMergeOption(const ScRange& rRange) :
> mnStartCol(rRange.aStart.Col()),
> mnStartRow(rRange.aStart.Row()),
> diff --git a/unusedcode.easy b/unusedcode.easy
> index 9284345..cdfe917 100644
> --- a/unusedcode.easy
> +++ b/unusedcode.easy
> @@ -143,8 +143,6 @@ ScAddInDocs::Insert(ScAddInDocs const*, unsigned
> short, unsigned short)
> ScAddInDocs::Insert(ScDocument* const&, unsigned short&)
> ScAddInDocs::Insert(ScDocument* const*, unsigned short)
> ScAddInDocs::Remove(ScDocument* const&, unsigned short)
> -ScAreaLinkSaveCollection::clear()
> -ScCellMergeOption::ScCellMergeOption()
> ScCellObj::SetFormulaResultDouble(double)
> ScCellObj::SetFormulaResultString(rtl::OUString const&)
> ScCellObj::SetFormulaWithGrammar(rtl::OUString const&, rtl::OUString
> const&, formula::FormulaGrammar::Grammar)
> @@ -167,10 +165,7 @@ ScConditionalFormats_Impl::Remove(unsigned short,
> unsigned short)
> ScCsvControl::ScCsvControl(Window*, ScCsvLayoutData const&, long)
> ScDBCollection::AnonDBs::erase(boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**,
> std::__cxx1998::vector<void*, std::allocator<void*> > >,
> std::__debug::vector<void*, std::allocator<void*> > >, ScDBData>)
> ScDBCollection::AnonDBs::size() const
> -ScDLL::Exit()
> -ScDPFieldControlBase::SetSelectedField(unsigned long)
> ScDPSaveDimension::Refresh(com::sun::star::uno::Reference<com::sun::star::sheet::XDimensionsSupplier>
> const&, std::__debug::list<rtl::OUString,
> std::allocator<rtl::OUString> > const&)
> -ScDdeLink::ResetValue()
> ScDocRowHeightUpdater::TabRanges::TabRanges()
> ScDocument::SetAllTabRangeNames(std::__debug::map<short, ScRangeName
> const*, std::less<short>, std::allocator<std::pair<short const,
> ScRangeName const*> > > const&)
> ScFilterDetect::impl_createFactory(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory>
> const&)
> @@ -183,8 +178,6 @@ ScHTMLColOffset_SAR::Replace(unsigned long const&,
> unsigned short)
> ScHTMLColOffset_SAR::Replace(unsigned long const*, unsigned short,
> unsigned short)
> ScHTMLColOffset_SAR::_ForEach(unsigned short, unsigned short,
> unsigned char (*)(unsigned long const&, void*), void*)
> ScHorizontalValueIterator::GetCurNumFmtInfo(short&, unsigned long&)
> -ScLeftFooterEditPage::GetRanges()
> -ScLeftHeaderEditPage::GetRanges()
> ScMyCellInfo::ScMyCellInfo()
> ScMyStyleRanges::SetStylesToRanges(ScRangeList*, rtl::OUString
> const*, short, rtl::OUString const*, ScXMLImport&)
> ScMyStyleRanges::SetStylesToRanges(ScRangeListRef, rtl::OUString
> const*, short, rtl::OUString const*, ScXMLImport&)
> @@ -200,8 +193,6 @@ ScRTFColTwips_SAR::Replace(unsigned long const&,
> unsigned short)
> ScRTFColTwips_SAR::Replace(unsigned long const*, unsigned short,
> unsigned short)
> ScRTFColTwips_SAR::_ForEach(unsigned short, unsigned short, unsigned
> char (*)(unsigned long const&, void*), void*)
> ScRangeData::ScRangeData(unsigned short)
> -ScRightFooterEditPage::GetRanges()
> -ScRightHeaderEditPage::GetRanges()
> ScSheetSourceDesc::GetCacheId() const
> ScSimpleRangeList::Range::contains(ScSimpleRangeList::Range const&) const
> ScStringCell::ScStringCell()
More information about the LibreOffice
mailing list