[Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

Noel Power nopower at suse.com
Tue Jan 31 02:43:31 PST 2012

On 31/01/12 09:11, Chr. Rossmanith wrote:
> Hi,
> please have a look at the comments marked with "crossmanith". I can 
> push on my own but a short review (and feedback) would be nice.

isn't it that  nInc can only be either 2, 4, 10 or 20 so that line 
indicated can't afaics be reached
and nSteps would seem to have a minimum of 2 imposed on it, looks like a 
typo ( or the limit was changed and not the comment or vice-versa )

patch looks fine to me, I wonder though why you changed

-    if ( !bLinear )
+    if ( rGradient.GetStyle() == GRADIENT_AXIAL )


More information about the LibreOffice mailing list