[Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Stephan Bergmann sbergman at redhat.com
Tue Jan 31 08:17:14 PST 2012

On 01/31/2012 03:22 PM, Noel Power wrote:
> I hate these remove list etc. type patches as they tend to be tricky and
> time consuming to look at ;-) . The patch looked ok for me, hopefully if
> I missed something ( 'cause these really are tricky ) then someone else
> will spot it. Anyway thanks again for the nice patch. So... pushed to
> master

Looks like you missed to run make check:

> LOG> 1. removeByIndex("1") ...OK
> LOG> removing a non existent object to get an exception
> LOG> 2. removeByIndex(): Expected exception - OK
> Method removeByIndex() finished with state FAILED
> LOG> removeByIndex(): PASSED.FAILED
> ***** State for sd.SdXCustomPresentation::com::sun::star::container::XIndexContainer ******
> [sd.SdXCustomPresentation::com::sun::star::container::XIndexContainer::removeByIndex()] is testcode: [removeByIndex()] - PASSED.FAILED

Guess Ivan's fix will rectify that.


More information about the LibreOffice mailing list