[Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Noel Power nopower at suse.com
Tue Jan 31 09:12:56 PST 2012


On 31/01/12 16:20, Ivan Timofeev wrote:
> 31.01.2012 19:55, Ivan Timofeev пишет:
>> I'll fix that.
>
> Hum; guys, what about
> - mpSdCustomShow->Remove(pPage->GetSdrPage());
> + ::std::remove(mpSdCustomShow->PagesVector().begin(), 
> mpSdCustomShow->PagesVector().end(),
> + pPage->GetSdrPage());
>
> mpSdCustomShow->Remove(pPage->GetSdrPage()); <- using the pointer as 
> the index??? Or it removes the first occurence of the page?
god bless your eyes, I read that even now '->Remove(pPage" when scanning 
it as RemovePage and was wondering what you were on about. should remove 
the first occurrence, care to fix  ?

Noel


More information about the LibreOffice mailing list