[Libreoffice] [PUSHED][PATCH V2] convert SdCustomShow from tools/list to vector
timofeev.i.s at gmail.com
Tue Jan 31 09:58:05 PST 2012
31.01.2012 21:44, Noel Power пишет:
> hey I've already proved my (non) STL credentials :-) , but.. if we are
> to believe the old code then
> mpSdCustomShow->Remove(pPage->GetSdrPage()); would call
> Container::Remove( void* p ) which would call Container::Remove(
> Container::GetPos( p ) ) which afaics deletes the first match :-) and
> that's what your patch seems to do, don't know if there is a briefer way
> to specify that but to me what you have looks fine
Ok. I'm not a STL expert, too.
Marking as pushed, thanks a lot Noel! :)
Someone with more shiny eyes & more strong STL/Container knowledge may
find another gotchas...
More information about the LibreOffice