[PATCH] fdo#45453: use integers rather than booleans

Lionel Elie Mamane lionel at mamane.lu
Tue Jan 31 12:32:55 PST 2012


for always-true and always-false tests.
Some databases have poor or no support for booleans.
---
 dbaccess/source/core/api/KeySet.cxx |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dbaccess/source/core/api/KeySet.cxx b/dbaccess/source/core/api/KeySet.cxx
index a7d9abe..1903110 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -228,8 +228,8 @@ namespace
     void appendOneKeyColumnClause( const ::rtl::OUString &tblName, const ::rtl::OUString &colName, ::rtl::OUStringBuffer &o_buf )
     {
         static ::rtl::OUString s_sDot(RTL_CONSTASCII_USTRINGPARAM("."));
-        static ::rtl::OUString s_sParam0(RTL_CONSTASCII_USTRINGPARAM(" ( TRUE = ? AND "));
-        static ::rtl::OUString s_sParam1(RTL_CONSTASCII_USTRINGPARAM(" = ? OR TRUE = ? AND "));
+        static ::rtl::OUString s_sParam0(RTL_CONSTASCII_USTRINGPARAM(" ( 1 = ? AND "));
+        static ::rtl::OUString s_sParam1(RTL_CONSTASCII_USTRINGPARAM(" = ? OR 1 = ? AND "));
         static ::rtl::OUString s_sParam2(RTL_CONSTASCII_USTRINGPARAM(" IS NULL ) "));
         o_buf.append(s_sParam0);
         o_buf.append(tblName);
@@ -247,16 +247,16 @@ void OKeySet::setOneKeyColumnParameter( sal_Int32 &nPos, const Reference< XParam
 {
     if ( _rValue.isNull() )
     {
-        _xParameter->setBoolean( nPos++, false );
+        _xParameter->setByte( nPos++, 0 );
         // We do the full call so that the right sqlType is passed to setNull
         setParameter( nPos++, _xParameter, _rValue, _nType, _nScale );
-        _xParameter->setBoolean( nPos++, true );
+        _xParameter->setByte( nPos++, 1 );
     }
     else
     {
-        _xParameter->setBoolean( nPos++, true );
+        _xParameter->setByte( nPos++, 1 );
         setParameter( nPos++, _xParameter, _rValue, _nType, _nScale );
-        _xParameter->setBoolean( nPos++, false );
+        _xParameter->setByte( nPos++, 0 );
     }
 }
 
-- 
1.7.7.3


--sdtB3X0nJg68CQEu--


More information about the LibreOffice mailing list