[PATCH] [REVIEW:3-5] fdo#36824 embedded hsqldb; in view computed row without alias makes whole file unusable

[Lionel Elie Mamane]

hsqldb fails to properly escape column names it generates
automatically from an expression in the "script" file it uses to
recreate the database (in memory) on load/connect.

The net effect is that any .odb file where such a view has been
defined cannot be reopened, unless one manually fiddles with the
database/script file in the .odb file seen as a zip file.

This patch fixes that, by saying that *any* expression that is not
already a column name *should* be escaped (instead of *not* escaped)
when seen as a column name/alias.

I hope no bad side-effects, but I'm not intimate with HSQLDB internals,
so never can be really sure.

Please apply to libreoffice-3-5.

-- 
Lionel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-36824-hsqldb-properly-escape-automatically-built.patch
Type: text/x-diff
Size: 1468 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120703/26c7ec36/attachment.patch>