logerrit review bug

[Miklos Vajna]

On Fri, Jun 29, 2012 at 09:59:57AM +0200, Miklos Vajna <vmiklos at suse.cz> wrote:
> Anyway, this is the first time I tried to use logerrit review, and I
> found 3 issues. The generated commandline should be like:
> 
> ssh logerrit gerrit review -m \"looks good\" --verified=+1 --code-review=2 1080c131c0c512a9d5273e860a48af13667bc9e8
> 
> But logerrit:
> 
> - prints " instead of \"
> - uses codereview insead of code-review (who tested this? ;) )
> - tries to use the changeid instead of the sha1 of the commit
> 
> The first two is trivial and I fixed it, the last one is something I'm
> not sure about - Norbert/Björn, care to have a look? The error message
> is:
> 
> fatal: "I7605eda6ef8111612ceb1ded79c0811de9ca7b25" is not a valid patch set
> 
> Just getting the sha1 from FETCH_HEAD is what I did manually for now,
> but that's not a solution - if I gerrit-cherry-pick two independent
> patches, then I have no idea how to get the original sha1 for the first
> one, unless we make gerrit-cherry-pick use git cherry-pick -x.

Hi Björn,

I want to point out that this is still an issue:

~/git/libreoffice/libreoffice-3-5$ ../master/logerrit review
no Change-Id given on the command line, reviewing change I3fa331d246160935f4feed21de69f9ec0c2e9994
was the change verified to build sucessfully (+) or found not to build (-) or none of that ()? +
is the code looking good (+), bad (-) or none of that ()? +
do you approve the change (+) too, or prefer someone else to do that ()? +
please type a friendly comment: looks ok
ssh logerrit gerrit review -m \"looks ok\" --verified=+1 --code-review=2 I3fa331d246160935f4feed21de69f9ec0c2e9994
~/git/libreoffice/libreoffice-3-5$ ssh logerrit gerrit review -m \"looks ok\" --verified=+1 --code-review=2 I3fa331d246160935f4feed21de69f9ec0c2e9994
fatal: "I3fa331d246160935f4feed21de69f9ec0c2e9994" is not a valid patch set
~/git/libreoffice/libreoffice-3-5$ cat .git/FETCH_HEAD 
281f3ec0a105175fb41e2b0455042fd29c7dc069                'refs/changes/57/257/1' of ssh://logerrit/core
~/git/libreoffice/libreoffice-3-5$ ssh logerrit gerrit review -m \"looks ok\" --verified=+1 --code-review=2 281f3ec0a105175fb41e2b0455042fd29c7dc069

(i.e. no error with the sha1, but still no idea how to get the original
sha1, in case i cherry-picked two change for review.)

Thanks for looking at it,

Miklos