Change in core[master]: fdo#35365 Set the default font color to black and the docume...

[Gerrit]

>From Thorsten Behrens <thb at documentfoundation.org>:

Thorsten Behrens has posted comments on this change.

Change subject: fdo#35365 Set the default font color to black and the document color to white.
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

(2 inline comments)

Looks good, either push as-is & do the rework onwards, or update patch

....................................................
File svtools/source/config/colorcfg.cxx
Line 465
This looks fine to me

Line 473
This needs some work - I find a few more occasions of FONTCOLOR in svx/source/*, apparently used in UI code - I suggest to convert that over to explicit Application::GetSettings().GetStyleSettings().GetWindowTextColor() there?

--
To view, visit https://gerrit.libreoffice.org/238
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia42ca7882f0d2dd1f2a304db5e4b5aaba23244fc
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen at canonical.com>
Gerrit-Reviewer: Björn Michaelsen <bjoern.michaelsen at canonical.com>
Gerrit-Reviewer: Jan Holesovsky <kendy at suse.cz>
Gerrit-Reviewer: Thorsten Behrens <thb at documentfoundation.org>