Change in core[master]: git-review integration: .gitreview for core repository added

[Gerrit]

>From James E. Blair <corvus at gnu.org>:

James E. Blair has posted comments on this change.

Change subject: git-review integration: .gitreview for core repository added
......................................................................


Patch Set 1: (3 inline comments)

Hi.  Hope you don't mind, I left a couple of inline comments.

....................................................
File .gitreview
Line 2: host=logerrit
If you set this to 'gerrit.libreoffice.org', you won't need an ssh host alias (but then you might need to set the gerrit username either using git config or by manually entering it, if your username is different than your workstation login).  Even so, that strikes me as being preferable to requiring an ssh host alias.

Line 5: defaultremote=logerrit
This will cause git-review to use "logerrit" as the name of the git remote, instead of "gerrit".  That's fine, but I'm curious why?

Line 6: defaultbranch=master
This should already be the default, but I guess it doesn't hurt.

--
To view, visit https://gerrit.libreoffice.org/262
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb72ef80f66f1d84a764bdc2629ad45f14acfe7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky <David.Ostrovsky at gmx.de>
Gerrit-Reviewer: Björn Michaelsen <bjoern.michaelsen at canonical.com>
Gerrit-Reviewer: James E. Blair <corvus at gnu.org>
Gerrit-Reviewer: Michael Stahl <mstahl at redhat.com>