Change in core[master]: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not ma...

Gerrit gerrit at gerrit.libreoffice.org
Sun Jul 8 03:35:35 PDT 2012


>From Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>:

Korrawit Pruegsanusak has posted comments on this change.

Change subject: fdo#51179: SearchAscii() is equal to indexOfAsciiL(), not match()
......................................................................


Patch Set 1:

I don't know if other filters, apart from ppt, should use match() or indexOfAsciiL(). I have no time to test them, sorry. So, I prefer this safer way -- rolling back to the equivalent of SearchAscii().

Also, I'm a bit reluctant between indexOfAsciiL() >= 0 and != -1, which means "not found". Which is better?

This should be pushed to -3-6 branch as well. Thanks :-)

--
To view, visit https://gerrit.libreoffice.org/264
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c3160be1c61162f6a62a7e14c4efb7bedccdcc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>
Gerrit-Reviewer: Korrawit Pruegsanusak <detective.conan.1412 at gmail.com>



More information about the LibreOffice mailing list