Change in core[master]: Remove ugly statics in comphelper

Gerrit gerrit at gerrit.libreoffice.org
Mon Jul 9 01:29:05 PDT 2012


>From Björn Michaelsen <bjoern.michaelsen at canonical.com>:

Björn Michaelsen has uploaded a new change for review.

Change subject: Remove ugly statics in comphelper
......................................................................

Remove ugly statics in comphelper

in 'comphelper\source\misc\logging.cxx' we can read :
    // (if ::rtl::OUString had an indexOfAscii, we could save those
ugly statics ...)

Well, it has kind of and indexOfAsciiL can be used if length is provided.

This patch is untested, so please check it before applying.
Especially, I've not checked for the includes for 'strlen'.

Change-Id: Ib241ea7d3766817e85977b4cd0ca27d5780c2616
---
M comphelper/source/misc/logging.cxx
1 file changed, 9 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/269/1
--
To view, visit https://gerrit.libreoffice.org/269
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib241ea7d3766817e85977b4cd0ca27d5780c2616
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Björn Michaelsen <bjoern.michaelsen at canonical.com>
Gerrit-Reviewer: Christophe JAILLET <christophe.jaillet at wanadoo.fr>



More information about the LibreOffice mailing list