[PUSHED][PATCH] build problem with gcc 4.5.2

Bjoern Michaelsen bjoern.michaelsen at canonical.com
Mon Jul 9 02:17:01 PDT 2012

Hi Terrence,

On Mon, Jul 09, 2012 at 09:47:18AM +0100, Michael Meeks wrote:
> On Sat, 2012-07-07 at 16:25 -0400, Terrence Enger wrote:
> > On Sat, 2012-07-07 at 21:59 +0200, David Ostrovsky wrote:
> > > May I kindly ask you to use in future our new Code Review System gerrit:
> > 
> > Alas, gerrit requires OpenId, which I do not have.  This is
> > deliberate, for reasons discussed in the subthread
> 	Hey - that's fine - there is no major problem with people continuing to
> post PATCH Subject mails here to have them reviewed and pushed. Gerrit
> is not intended to be "the only way" to get code in :-)

Well, I have a patch pickup script ready (but still untested), that will make
that rather seamless soon anyway. If you:

* create a proper patch against master with 'git format-patch'
* Have [PATCH] or [ONGERRIT] at the begin of the subject
* send or cc it to gerrit at libreoffice.org

it will then be uploaded to gerrit en passent. This will allow you to have the
patch right there on gerrit too or it will report back if there is any trouble
with the patch.



More information about the LibreOffice mailing list