Change in core[master]: Replaced deprecated tools/String with OUString in ScAddInCol

[Gerrit]

>From Eike Rathke <erack at redhat.com>:

Eike Rathke has posted comments on this change.

Change subject: Replaced deprecated tools/String with OUString in ScAddInCol
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

2 more nitpicks ;-)

....................................................
File sc/source/core/tool/addincol.cxx
Line 938:                                         ::rtl::OUString aLocalName = ::rtl::OUString( aLocalU );
aLocalU is already OUString, no need for yet another conversion, so that would be simply

 ::rtl::OUString aLocalName( aLocalU );

However, aLocalU was a temporary OUString used to obtain the value from getDisplayFunctionName() and then assign it to String, this can be eliminated now and instead of aLocalU the aLocalName can be used, just declare it above instead of aLocalU.

Line 950:                                         ::rtl::OUString aDescription( aDescU );
Here the same, the temporary aDescU isn't needed anymore, directly use aDescription instead.

--
To view, visit https://gerrit.libreoffice.org/258
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7059f10617b9a33ba63690c980b96d95d9023c55
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Sören Möller <soerenmoeller2001 at gmail.com>
Gerrit-Reviewer: Eike Rathke <erack at redhat.com>
Gerrit-Reviewer: Markus Mohrhard <markus.mohrhard at googlemail.com>
Gerrit-Reviewer: Sören Möller <soerenmoeller2001 at gmail.com>