gerrit lame / non-reviews ...

Michael Meeks michael.meeks at suse.com
Mon Jul 9 05:29:42 PDT 2012


Hi guys,

On Mon, 2012-07-09 at 10:28 +0000, Gerrit wrote:
> Björn Michaelsen has posted comments on this change.

	Let me pick on Bjoern because he is a big guy :-)

> Change subject: renamed German variables (in sw/source/core/crsr/)
> ......................................................................
> Patch Set 1: Looks good to me, but someone else must approve

	Until we can either turn down the gerrit fire-hose; or work out some
way of improving the flow:

	*please* have some consideration for the people on this list.

	If you would not send a content-free mail of a dozen lines saying "me
too" - then please do not do bogus/empty "looks good to me but doesn't
close or merge the patch" type reviews.

	If you agree a patch looks good; just merge it. If you like the look of
it but are not sure - please consider staying quiet for now :-) I (for
one) don't want to have a +1 infested Apache-style list full of poorly
quoted context and almost no signal :-)

	If a review has been done, and the patch is ok lets merge the patch :-)
it avoids someone else having to do that work, and worse a ton of people
having to read their mailbox full of big mail with ~identical subjects
many with banal content.

	:-)

	Thanks !

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list