Improve doc about gerrit/setup
Christophe JAILLET
christophe.jaillet at wanadoo.fr
Mon Jul 9 22:42:02 PDT 2012
Le 10/07/2012 00:22, David Ostrovsky a écrit :
>
> On 09.07.2012 23:23, Lionel Elie Mamane wrote:
>> It is a wiki, you can correct it directly yourself. Also for the rest
>> of your remarks.
>>
>
> actually we have more then one gerrit command wrapper tool (and
> documentation)
> that you may want give a try:
>
> http://wiki.documentfoundation.org/Development/GitReview
>
> and of course it is also wiki ... ,-)
>
> Regards
> David
3 more points to have it well configured in my box :
1) Also I came across a "remote: ERROR: missing Change-Id in commit
message" after my first proposal on gerrit.
Googling, to had this Change-Id, I found that I had to run
scp -p -P 29418 <username on gerrit.libreoffice.or
<https://gerrit.libreoffice.org/>g>@gerrit.libreoffice.org:hooks/commit-msg
.git/hooks
I've not found anything on it on the wiki, and as I don't anderstand
this command line, I'll let anyone who does, update the wiki.
2) With that, i'm able to connect and transfer the patch BUT I still
have the "remote: ERROR: missing Change-Id in commit message"
Attached is what I get from a "git format-patch HEAD~1" (I'll submit it
via gerrit, as soon as I can have it work)
Here is the output I get with "./logerrit submit":
>>>>>>>>>>>>>>>>>
$ ./logerrit submit
no branch specified, guessing current branch master
Counting objects: 70420, done.
Compressing objects: 100% (9656/9656), done.
Writing objects: 100% (48845/48845), 15.70 MiB | 95 KiB/s, done.
Total 48845 (delta 40284), reused 44589 (delta 37492)
remote: Resolving deltas: 100% (40284/40284)
remote: Processing changes: refs: 1, done
remote: ERROR: missing Change-Id in commit message
remote: Suggestion for commit message:
remote: Remove a useless include
remote:
remote: Change-Id: Ifa3bb68bfa88ba2bbe12611eb67936038780f2d0
To ssh://logerrit/core
! [remote rejected] HEAD -> refs/for/master (missing Change-Id in
commit message)
error: failed to push some refs to 'ssh://logerrit/core'
>>>>>>>>>>>>>>>>>
The generated patch has a 'Change-Id', so I would expect that
"./logerrit submit" would do the same. Where I'm wrong ?
3) Is it normal to send 15.70 MiB of data for a 5.3 Ko patch ???
Thanks in advance for your help.
Best regards,
Christophe JAILLET
-------------- next part --------------
>From c203061eb60794cfdba03dc0faa6d8b5afc5879f Mon Sep 17 00:00:00 2001
From: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
Date: Mon, 9 Jul 2012 23:40:03 +0200
Subject: [PATCH] Use rtl_zeroMemory in place of rtl_fillMemory(..., 0)
Change-Id: I237ef0d7496a62d76c0263877a66b53d4f8709e1
---
canvas/source/directx/dx_surfacebitmap.cxx | 14 +++++++-------
sal/inc/osl/file.hxx | 4 ++--
sc/source/filter/qpro/qprostyle.cxx | 8 ++++----
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/canvas/source/directx/dx_surfacebitmap.cxx b/canvas/source/directx/dx_surfacebitmap.cxx
index d0ca06d..413c17e 100644
--- a/canvas/source/directx/dx_surfacebitmap.cxx
+++ b/canvas/source/directx/dx_surfacebitmap.cxx
@@ -83,7 +83,7 @@ namespace dxcanvas
sal_uInt8* DXColorBuffer::lock() const
{
#if DIRECTX_VERSION < 0x0900
- rtl_fillMemory((void *)&aSurfaceDesc,sizeof(DDSURFACEDESC),0);
+ rtl_zeroMemory((void *)&aSurfaceDesc,sizeof(DDSURFACEDESC));
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
const DWORD dwFlags = DDLOCK_NOSYSLOCK|DDLOCK_SURFACEMEMORYPTR|DDLOCK_WAIT|DDLOCK_READONLY;
if(SUCCEEDED(mpSurface->Lock(NULL,&aSurfaceDesc,dwFlags,NULL)))
@@ -344,7 +344,7 @@ namespace dxcanvas
#if DIRECTX_VERSION < 0x0900
DDSURFACEDESC aSurfaceDesc;
- rtl_fillMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC),0);
+ rtl_zeroMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC));
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
const DWORD dwFlags = DDLOCK_NOSYSLOCK|DDLOCK_SURFACEMEMORYPTR|DDLOCK_WAIT|DDLOCK_READONLY;
@@ -468,7 +468,7 @@ namespace dxcanvas
{
#if DIRECTX_VERSION < 0x0900
DDSURFACEDESC aSurfaceDesc;
- rtl_fillMemory( &aSurfaceDesc,sizeof(DDSURFACEDESC),0 );
+ rtl_zeroMemory( &aSurfaceDesc,sizeof(DDSURFACEDESC) );
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
if( FAILED(mpSurface->Lock( NULL,
@@ -541,7 +541,7 @@ namespace dxcanvas
#if DIRECTX_VERSION < 0x0900
DDSURFACEDESC aSurfaceDesc;
- rtl_fillMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC),0);
+ rtl_zeroMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC));
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
const DWORD dwFlags = DDLOCK_NOSYSLOCK|DDLOCK_SURFACEMEMORYPTR|DDLOCK_WAIT|DDLOCK_READONLY;
@@ -623,7 +623,7 @@ namespace dxcanvas
#if DIRECTX_VERSION < 0x0900
DDSURFACEDESC aSurfaceDesc;
- rtl_fillMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC),0);
+ rtl_zeroMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC));
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
const DWORD dwFlags = DDLOCK_NOSYSLOCK|DDLOCK_SURFACEMEMORYPTR|DDLOCK_WAIT|DDLOCK_WRITEONLY;
@@ -703,7 +703,7 @@ namespace dxcanvas
#if DIRECTX_VERSION < 0x0900
DDSURFACEDESC aSurfaceDesc;
- rtl_fillMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC),0);
+ rtl_zeroMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC));
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
const DWORD dwFlags = DDLOCK_NOSYSLOCK|DDLOCK_SURFACEMEMORYPTR|DDLOCK_WAIT|DDLOCK_WRITEONLY;
@@ -761,7 +761,7 @@ namespace dxcanvas
#if DIRECTX_VERSION < 0x0900
DDSURFACEDESC aSurfaceDesc;
- rtl_fillMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC),0);
+ rtl_zeroMemory(&aSurfaceDesc,sizeof(DDSURFACEDESC));
aSurfaceDesc.dwSize = sizeof(DDSURFACEDESC);
const DWORD dwFlags = DDLOCK_NOSYSLOCK|DDLOCK_SURFACEMEMORYPTR|DDLOCK_WAIT|DDLOCK_READONLY;
diff --git a/sal/inc/osl/file.hxx b/sal/inc/osl/file.hxx
index 16f7a06..e93682d 100644
--- a/sal/inc/osl/file.hxx
+++ b/sal/inc/osl/file.hxx
@@ -444,7 +444,7 @@ public:
VolumeInfo( sal_uInt32 nMask ): _nMask( nMask )
{
_aInfo.uStructSize = sizeof( oslVolumeInfo );
- rtl_fillMemory( &_aInfo.uValidFields, sizeof( oslVolumeInfo ) - sizeof( sal_uInt32 ), 0 );
+ rtl_zeroMemory( &_aInfo.uValidFields, sizeof( oslVolumeInfo ) - sizeof( sal_uInt32 ) );
_aInfo.pDeviceHandle = &_aDevice._aHandle;
}
@@ -692,7 +692,7 @@ public:
FileStatus( sal_uInt32 nMask ): _nMask( nMask )
{
_aStatus.uStructSize = sizeof( oslFileStatus );
- rtl_fillMemory( &_aStatus.uValidFields, sizeof( oslFileStatus ) - sizeof( sal_uInt32 ), 0 );
+ rtl_zeroMemory( &_aStatus.uValidFields, sizeof( oslFileStatus ) - sizeof( sal_uInt32 ) );
}
/** Destructor.
diff --git a/sc/source/filter/qpro/qprostyle.cxx b/sc/source/filter/qpro/qprostyle.cxx
index f3556d6..9284bb29 100644
--- a/sc/source/filter/qpro/qprostyle.cxx
+++ b/sc/source/filter/qpro/qprostyle.cxx
@@ -55,10 +55,10 @@
ScQProStyle::ScQProStyle()
{
- rtl_fillMemory (maAlign, sizeof (maAlign), 0);
- rtl_fillMemory (maFont, sizeof (maFont), 0);
- rtl_fillMemory (maFontRecord, sizeof (maFontRecord), 0);
- rtl_fillMemory (maFontHeight, sizeof (maFontHeight), 0);
+ rtl_zeroMemory (maAlign, sizeof (maAlign));
+ rtl_zeroMemory (maFont, sizeof (maFont));
+ rtl_zeroMemory (maFontRecord, sizeof (maFontRecord));
+ rtl_zeroMemory (maFontHeight, sizeof (maFontHeight));
}
void ScQProStyle::SetFormat( ScDocument *pDoc, sal_uInt8 nCol, sal_uInt16 nRow, SCTAB nTab, sal_uInt16 nStyle )
--
1.7.9
More information about the LibreOffice
mailing list