[PUSHED] Re: [PATCH] cleanup java code and update to Java5, including generics (36)

Stephan Bergmann sbergman at redhat.com
Tue Jul 10 07:09:49 PDT 2012

On 06/29/2012 10:07 PM, Michael Stahl wrote:
> [PATCH 22/36] Java5 update - convert code to use generics
> [PATCH 36/36] Java5 updates - update code to use generics
> the above 2 patches seem to change interfaces of classes in "ridljar"
> and "javaunohelper" that are likely part of the stable URE ABI, and
> shouldn't be changed; i think adding type parameters is OK (after all
> the Java standard libraries had these retrofitted as well, and they
> don't exist at runtime anyway thanks to type erasure) but things like
> replacing Hashtable with Map is not OK, so i've reverted those parts.

Things like changing from

     Hashtable context_entries);


     Hashtable<String, Object> context_entries);

(javaunohelper/com/sun/star/comp/helper/Bootstrap.java) are technically 
incompatible:  Old client code could legitimately have called

   createInitialComponentContext(new Hashtable<Object, Object>())

which now fails to compile.  However, chances of such client code are 
pretty low, so I'd say the changes are OK.


More information about the LibreOffice mailing list