[PUSHED] Re: [PATCH] Convert SV_DECL_PTRARR_SORT (8)

Michael Stahl mstahl at redhat.com
Thu Jul 12 05:16:50 PDT 2012


On 11/07/12 13:41, Noel Grandin wrote:
> Hi
> 
> These patches convert various places to use normal STL containers.
> 
> Particular attention should be paid to patch 0007, since it introduces a 
> new template container class sorted_vector
> 
> These patches all pass a full "make check"

thanks, pushed.

patch #4 introduced a memory leak, fixed it by using boost::ptr_set.

patch #7 had weird copyright headers but i just saw your other mail that
that was an error so i've taken the liberty to exchange these for the
standard one.

i've also changed the sorted_vector to inherit private from std::vector,
as calling vector::insert on it would be a bug anyway, so it should not
be in the public interface.



More information about the LibreOffice mailing list