[PATCH] [REVIEW:3-5] horrible performance regression

[Lionel Elie Mamane]

On Tue, Jul 17, 2012 at 12:10:05AM +0200, Lionel Elie Mamane wrote:
> Please cherry-pick 0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
> (http://cgit.freedesktop.org/libreoffice/core/commit/?id=0cda6605844ef68e45db7a7c05cc4d09ef2bc49a
>  and patch also attached)
> to libreoffice-3-6 in time for rc2.

> I'll make a backport to libreoffice-3-5 later this week

So, the sorry situation is that backporting this without also
backporting e581bef6dfc03d0bab9de1485c6f6cdcd034d581 is pointless.

That's more than I'm comfortable with on a stable branch, but OTOH, if
we don't fix this, we'd leave a huge problem for users of embedded
HSQLDB. So I reluctantly ask for backport to libreoffice-3-5.

Additionally, e581bef6dfc03d0bab9de1485c6f6cdcd034d581 moderately
intertwined with 773668c6ab0963f56f98270b29d595f5df7c4bb2, so I
decided that porting e581bef6dfc03d0bab9de1485c6f6cdcd034d581 without
773668c6ab0963f56f98270b29d595f5df7c4bb2 is actually more risky than
without it.


So the backport of these three commits is attached as patches. I
squashed with fixups that happened shortly after these commits.

-- 
Lionel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-OKeySet-tryRefetch-and-refreshRow-share-most-of-thei.patch
Type: text/x-diff
Size: 6393 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120718/616b5844/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-i-102625-avoid-fetching-same-row-twice-in-different-.patch
Type: text/x-diff
Size: 15916 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120718/616b5844/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-fdo-51239-refresh-row-lazily-when-data-is-requested.patch
Type: text/x-diff
Size: 13892 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120718/616b5844/attachment-0005.patch>