[REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import

Markus Mohrhard markus.mohrhard at googlemail.com
Fri Jul 20 11:39:41 PDT 2012


2012/7/20 Kohei Yoshida <kohei.yoshida at gmail.com>:
> On 07/19/2012 12:31 PM, Eike Rathke wrote:
>> Hi,
>> Please review and cherry-pick to 3-6 and 3-6-0
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b7dbc768a71ccfb567e3b2979e57d0d1318977cf
>> that fixes https://bugs.freedesktop.org/show_bug.cgi?id=52205
> I reviewed and tested several csv files and one related pivot table use
> case, and it did fix the bug.
> The old behavior for ScSetStringParam::mbSetTextCellFormat was somewhat
> confusing and there was a reason for that.  I now slightly changed the
> behavior of that flag and you commit kept that new behavior.  But I couldn't
> reproduce the original issue that the old behavior was intended to fix, so I
> think it's safe to keep the new behavior.
> Pushed to the -3-6 branch with my sign-off.   We need 2 more sign-offs to
> push this to the -3-6-0 branch (I assume?).

Looks good to me. One more needed for 3-6-0.

More information about the LibreOffice mailing list