ScSetStringParam::mbSetTextCellFormat (was: [REVIEW 3-6, 3-6-0] [PUSHED 3-6] resolved fdo#52205 do not force all text cells in CSV import)

[Eike Rathke]

Hi Kohei,

On Friday, 2012-07-20 09:25:54 -0400, Kohei Yoshida wrote:

> The old behavior for ScSetStringParam::mbSetTextCellFormat was
> somewhat confusing and there was a reason for that.  I now slightly
> changed the behavior of that flag and you commit kept that new
> behavior.

I inspected places where mbSetTextCellFormat is used and in
sc/source/filter/rtf/eeimpars.cxx line 334 in
ScEEImport::WriteToDocument() the if(bSimple) case looks similar
suspicious, that's used for RTF and HTML import. But there's no extra
handling for a forced text case as it is in CSV import, so this may be
not as easy to fix. I didn't investigate yet deeper, just imported
a simple number from HTML, and that indeed gets imported as text now.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120720/068d1bd0/attachment.pgp>