[PATCH (partial)] fdo#48549 System::Beep() removal
sbergman at redhat.com
Mon Jul 23 09:20:25 PDT 2012
On 07/23/2012 05:42 PM, Eike Rathke wrote:
> On Monday, 2012-07-23 16:01:56 +0200, Philipp Riemer wrote:
>> But I do not know what the general opinion of the LO developers for
>> that cases is... Maybe they are happy without any logging in there...
>> Whould love to hear from the others what they think.
> In general such cases deserve a SAL_WARN,
...or, depending on the nature of the event that caused the beep, merely
a SAL_LOG. See
for a (potentially unhelpful) differentiation of the two's intended uses.
The general idea is that SAL_WARN is for events that "do not normally
happen." And something like "in the Basic IDE, user attempts to set a
breakpoint on a line that contains no code" (whether or not that is
something that used to trigger a beep; I did not check) in my
interpretation does not fall into that category and thus should be
logged with SAL_LOG. But a somewhat gray area indeed...
More information about the LibreOffice