[PUSHED][3-5][3-6][3-6-0] Re: [REVIEW 3-6] fdo#50975 crash in about dialog on RHEL-5
dtardon at redhat.com
Mon Jul 23 23:20:33 PDT 2012
On Mon, Jul 23, 2012 at 06:47:34PM +0200, Miklos Vajna wrote:
> On Mon, Jul 23, 2012 at 05:59:29PM +0200, Michael Stahl <mstahl at redhat.com> wrote:
> > i was wondering why you'd removed the content of the then branch until i
> > realized that that is actually error handling code for a failed close
> > call... it's really painful to read code with 2 side effects in the if
> > clause....
> +1 from me, one more needed.
+1 and pushed.
More information about the LibreOffice