[REVIEW 3-6][REVIEW 3-6-0] prevent crash in malformed pivot table loaded from .xls

Eike Rathke erack at redhat.com
Tue Jul 24 05:49:23 PDT 2012


Hi Stephan,

On Tuesday, 2012-07-24 14:26:58 +0200, Stephan Bergmann wrote:

> >Please review and cherry-pick to 3-6 and 3-6-0
> >http://cgit.freedesktop.org/libreoffice/core/commit/?id=3536fcd999f16525f20a1fff5c2512b565511d7b
> 
> >+ return pData && nComp == pData2->GetValue();
> 
> that should be return pData2 && ..., right?

hmpf.. of course, thanks for noticing.
So, this is also needed:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b2ec8c2a3478047a270b31bc25ad1d782401306

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120724/eb6c5175/attachment-0001.pgp>


More information about the LibreOffice mailing list