[PUSHED][3-6-0] Re: [PUSHED 3-6][REVIEW 3-6-0 2/3] prevent crash in malformed pivot table loaded from .xls

[Michael Stahl]

On 24/07/12 15:02, Petr Mladek wrote:
> Stephan Bergmann píše v Út 24. 07. 2012 v 14:58 +0200:
>> On 07/24/2012 02:49 PM, Eike Rathke wrote:
>>> On Tuesday, 2012-07-24 14:26:58 +0200, Stephan Bergmann wrote:
>>>>> Please review and cherry-pick to 3-6 and 3-6-0
>>>>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=3536fcd999f16525f20a1fff5c2512b565511d7b
>>>>
>>>>> + return pData && nComp == pData2->GetValue();
>>>>
>>>> that should be return pData2 && ..., right?
>>>
>>> hmpf.. of course, thanks for noticing.
>>> So, this is also needed:
>>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b2ec8c2a3478047a270b31bc25ad1d782401306
>>
>> Patch looks reasonable overall, so pushed the combination of the above 
>> two to libreoffice-3-6 as 
>> <http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=ca9607ac8ed43d29125a0a2d22a938ec8f414841> 
>> now.
>>
>> Two more reviews needed for libreoffice-3-6-0.
> 
> Yup. it looks sane => +1
> 
> One more approval needed for 3-6-0 branch.

that looks simple enough.

pushed to libreoffice-3-6-0