[PATCH] fixed Replace all message in Basic IDE

Stephan Bergmann sbergman at redhat.com
Thu Jul 26 06:30:21 PDT 2012


On 07/25/2012 07:28 PM, Eike Rathke wrote:
> On Wednesday, 2012-07-25 16:11:24 +0200, János Uray wrote:
>> In Basic IDE, "Replace all" said "Search key replaced  times", so without
>> the number.
>
> Hmm.. actually it should be a character corresponding to the value of
> nFound, not just a blank..

...but sal_uInt16 = sal_Unicode, at least for non-MSVC, so 
rtl::OUString::valueOf(nFound) does not do what one would expect...

-Stephan

>> This patch fixes it. (The nFound was treated as a character instead of an
>> integer.)
>
>> --- a/basctl/source/basicide/basides1.cxx
>> +++ b/basctl/source/basicide/basides1.cxx
>> -                    sal_uInt16 nFound = 0;
>> +                    int nFound = 0;
>
> valueOf() is defined for sal_... types, so instead of using int here it
> should be sal_Int32.


More information about the LibreOffice mailing list