[PATCH] gtk: listbox border was not rendered

[Ivan Timofeev]

Hi Ruslan,

On 28.07.2012 15:08, Ruslan Kabatsayev wrote:
> This mostly looks good, but breaks a bit border for oxygen-gtk

I have just installed it, yeah - it is broken... :(

>(which somehow has worked before the patch, unlike other themes).

Strange.

> I'd suggest using getFrameWidth() to adjust the shadow rect.

AFAICS vcl makes listbox a child of borderwindow, which receives the 
border sizes via DecorationView::DrawFrame:
http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#1212
(for oxygen-gtk it is 2 for each border);

shrinks the listbox size by that border in Resize():
http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#2066

draws CTRL_LISTBOX PART_WINDOW (i.e. calls gtk_paint_shadow with 
"scrolled_window") with its size (i.e. client+borders):
http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#1362

Try to build with my patch and the attached diff applied, IMHO LibO will 
do things right. But probably I missed something (as usual :).

> OTOH, we've done quite some customizations in oxygen-gtk before to
> make it look better with LibO, so maybe this is what should be changed
> on oxygen-gtk side.

It would be great if you could check it. :)

Regards,
Ivan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: black-border-treelistbox.diff
Type: text/x-diff
Size: 909 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120728/51159ae5/attachment.diff>