[PATCH] Cleanup in Tools -> Options -> User Data

[Miklos Vajna]

Hi János,

Nice work! :) I wanted to push this, but it seems it causes a crash here
when I do the followings:

- start ./soffice.bin
- open tools -> options -> user data
- don't change anything, just click OK
- file -> exit -> abort

Here is the backtrace:

(gdb) bt
#0  0x00007ffff6e30d95 in raise () from /lib64/libc.so.6
#1  0x00007ffff6e322ab in abort () from /lib64/libc.so.6
#2  0x00007ffff6e72700 in malloc_printerr () from /lib64/libc.so.6
#3  0x00007fffe0083c18 in SwModule::Notify (this=0x15e67f0, rHint=...) at /git/libreoffice/master/sw/source/ui/app/apphdl.cxx:766
#4  0x00007ffff5107db4 in SfxBroadcaster::Broadcast(SfxHint const&) () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libsvllo.so
#5  0x00007ffff54cd96d in SfxTerminateListener_Impl::notifyTermination(com::sun::star::lang::EventObject const&) ()
   from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libsfxlo.so
#6  0x00007fffe3dbfc2c in framework::Desktop::terminate() () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/../program/libfwklo.so
#7  0x00007fffe3ce3aed in framework::CloseDispatcher::implts_terminateApplication() ()
   from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/../program/libfwklo.so
#8  0x00007fffe3ce5b9b in framework::CloseDispatcher::impl_asyncCallback(void*) ()
   from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/../program/libfwklo.so
#9  0x00007ffff36c76ea in vcl::EventPoster::LinkStubDoEvent_Impl(void*, void*) () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#10 0x00007ffff3769918 in ImplWindowFrameProc(Window*, SalFrame*, unsigned short, void const*) ()
   from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#11 0x00007ffff377249e in SalGenericDisplay::DispatchInternalEvent() () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#12 0x00007fffeaee4952 in GtkData::userEventFn(void*) () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvclplug_gtklo.so
#13 0x00007fffeaee49d9 in call_userEventFn () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvclplug_gtklo.so
#14 0x00007fffe8a8a58d in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
#15 0x00007fffe8a8ad88 in ?? () from /usr/lib64/libglib-2.0.so.0
#16 0x00007fffe8a8af59 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
#17 0x00007fffeaee46b9 in GtkData::Yield(bool, bool) () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvclplug_gtklo.so
#18 0x00007ffff34e4c11 in Application::Yield(bool) () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#19 0x00007ffff34e4cc7 in Application::Execute() () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#20 0x00007ffff792371a in desktop::Desktop::Main() () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libsofficeapp.so
#21 0x00007ffff34ee5e9 in ImplSVMain() () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#22 0x00007ffff34eef15 in SVMain() () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libvcllo.so
#23 0x00007ffff7954d66 in soffice_main () from /git/libreoffice/master/solver/unxlngx6.pro/installation/opt/program/libsofficeapp.so
#24 0x000000000040069b in main ()

And it's really DELETEZ(pUserOptions); -- so hopefully not a false
positive. :) Please fix this crash-on-exit, then I'm happy to push this
one.

Thanks,

Miklos