[PUSHED] Re: [PATCH] Final stretch of converting SV_DECL_PTRARR to STL containers stage 3/3

Michael Stahl mstahl at redhat.com
Tue Jul 31 13:38:02 PDT 2012

On 28/07/12 00:51, Michael Stahl wrote:
> On 23/07/12 09:34, Noel Grandin wrote:
>> bad-SVL-SfxListener.diff
>> bad-SW-Convert-SV_DECL_PTRARR_SORT_DEL-InsCapOptArr-to-boos.patch
>> bad-SW-Convert-SV_DECL_PTRARR_SORT-SwSortElements-to-std-ve.patch
>> bad-SW-NdHints.diff
>>    crashes nowhere near the changed code, so I have no idea what I'm 
>> doing wrong
> haven't had time to look at these

i think i've pushed one of these and Caolan and me have converted the
rest; needed to add a new template parameter to sorted_vector to allow
for cases like the hints array that only sort the entries by operator<
but check for duplicates by comparing that it's the same pointer/object.

by the way, is there any way to force a template parameter that itself
has template parameters to use the same type parameters as the type that
it's a template parameter to?  would be useful here...

so with the subsequent removal of svarray.hxx (yay!) there are still
obsolete containers left in tools/inc/tools/{contnr,list,unqidx}.hxx if
you feel bored  :)

More information about the LibreOffice mailing list